# Consolidate infra config from tfvars files into config module

* Status: accepted
* Deciders: @lorenyu @rocketnova @kyeah @acouch
* Date: 2023-09-07

Technical Story: [Replace configure scripts with project/app config variables #312](https://github.com/navapbc/template-infra/issues/312)

## Context

Currently, application infrastructure configuration is split across config modules (see [app-config](https://github.com/HHS/simpler-grants-gov/blob/main/infra/frontend/app-config/README.md)) as well as .tfvars files in each of the application's infra layers - infra/app/build-repository, infra/app/database, and infra/app/service. As @kyeah pointed out, it’s easy to make mistakes when configuration is spread across multiple files, and expressed a desire to manage manage tfvars across environments all in a single file the way that some applications do for application configuration. And as @acouch [pointed out](https://github.com/navapbc/template-infra/pull/282#discussion_r1219930653), there is a lot of duplicate code with the configure scripts (setup-current-account.sh, configure-app-build-repository.sh, configure-app-database.sh, configure-app-service.sh) that configure the backend config and variable files for each infrastructure layer, which increases the burden of maintaining the configuration scripts.

## Overview

This ADR proposes the following:

* Move all environment configuration into [app-config](https://github.com/HHS/simpler-grants-gov/blob/main/infra/frontend/app-config/README.md) modules
* Remove the need for .tfvars files
* Remove the configuration scripts that are currently used for configuring each infrastructure layer

Benefits:

* All configuration can now be managed in the [app-config](https://github.com/HHS/simpler-grants-gov/blob/main/infra/frontend/app-config/README.md) module.
* Custom configuration scripts now longer need to be maintained
* Eliminates the need to specify -var-file option when running terraform apply, which reduces the need for terraform wrapper scripts

## Links

* Builds on [ADR-0004](/product/decisions/infra/0004-separate-terraform-backend-configs-into-separate-config-files.md)


---

# Agent Instructions: Querying This Documentation

If you need additional information that is not directly available in this page, you can query the documentation dynamically by asking a question.

Perform an HTTP GET request on the current page URL with the `ask` query parameter:

```
GET https://wiki.simpler.grants.gov/product/decisions/infra/0008-consolidate-infra-config-from-tfvars-files-into-config-module.md?ask=<question>
```

The question should be specific, self-contained, and written in natural language.
The response will contain a direct answer to the question and relevant excerpts and sources from the documentation.

Use this mechanism when the answer is not explicitly present in the current page, you need clarification or additional context, or you want to retrieve related documentation sections.